Eliminate redundant type assertions #1156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the compiler sources with the intent to eliminate any redundant type assertions that might involve a redundant dynamic check at runtime when compiling to WebAssembly.
Typical patterns are
which are nops in TS but upcasts in AS, where refactoring these to
does just one dynamic check instead of two at the expense of an additional local that Binaryen will most likely collapse again.
Also makes relevant code a little more verbose as a side-effect, which some might find helpful to keep track of things when working with the sources.